Fix Dockerfile CMD to correct instance manager binary name. #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aznashwan
force-pushed
the
fix-docker-cmd
branch
from
154ba5b
to
639cc2d
Compare
This patch fixes the CMD in the longhorn-instance-manager container image. Signed-off-by: Nashwan Azhari <nazhari@cloudbasesolutions.com>
aznashwan
force-pushed
the
fix-docker-cmd
branch
from
639cc2d
to
f8ea3e0
Compare
|
I am unfortunately unsure what the commit message linter wants from me, but I'll gladly take suggestions on how to fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
None.
Considering the
longhorn-instance-managerexecutable requires at least some arguments to it so everyone who's ever used this image overrodeCMD, this is not really an issue in practice, it's only incorrect if you pass no arguments.What this PR does / why we need it:
Because the current
CMDarg which gets passed totinidoesn't exist, leading to this error if you run the image plainly:$ docker run -it longhornio/longhorn-instance-manager:v1.7.0 [FATAL tini (7)] exec longhorn failed: No such file or directorySpecial notes for your reviewer:
Binary built as
longhorn-instance-managerhere.Binary added to Docker image under the same
longhorn-instance-managername here.I am 95% sure the cause of this is someone just copy-pasting the Engine Dockerfile, whose binary is indeed plainly named
longhorn.Additional documentation or context